cruxports4slack (pkgfile) scripts- submit/feedback thread

[kidd]

I'm having some troubles with a port I'm writting:
The program is 'fish', an interactive shell.

After doing the 'make install', the build script should append to /etc/shells
the following line:

/usr/bin/fish
my Pkgfile looks like this and when the tlz is created, it appends the line, not when installed

Code:

#package: fish (user friendly command line shell)
#Packaged by kidd

name=fish
version=1.22.3
release=1
source=(http://www.fishshell.org/files/1.22.3/$name-$version.tar.gz)
build() {
cd $name-$version
./configure --prefix=/usr --sysconfdir=/etc --mandir=/usr/man --libdir=/usr/lib --bindir=/usr/bin --localstatedir=/var --with-included-gettext
make || exit 1
make DESTDIR=$PKG install || exit 1
grep -li 'fish' /etc/shells || echo '/usr/bin/fish' >> /etc/shells
}

Browsing the tlz file I see doinst.sh is empty


Suggestions?

[M0E-lnx]

that is one of the disadvantages that I found to the cruxports thing. the number of available commands to the script file is somewhat limited.
Are you shipping a new /etc/shells with this package?
if you are then you should append the $PKG/etc/shells instead.
if you are not, then you should append the $PKG/install/doinst.sh to make this call

HTH